Functions: replace InstanceID by Messaging (master)#6395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
paulb777 reviewed Sep 2, 2020
There was a problem hiding this comment.
Looks great!
Please resolve CI and let's also get confirmation from @ryanwilson on the new interop approach in #6379
charlotteliang approved these changes Sep 2, 2020
paulb777 approved these changes Sep 3, 2020
Confirmed in-person. Added FCM iterop to Functions GHA paths based on the feedback. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstanceID (FCM token) is sent by Functions SDK when available to allow developers sending messages to the device from cloud functions. As Instance ID has been deprecated Functions SDK will take the token from FCM directly.