Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery.#6181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
@chliangGoogle I feel like there must be a LaunchCall associated with the feature. I think it would be useful to link it to the PR somehow. |
I'm still struggling with the nanopb encoding, once the code is ready for review, I will kick off a launchcal. |
@chliangGoogle Is this PR still relevant? If not please close. |
@paulb777 It is blocked on internal PM review. |
Coverage ReportAffected SDKs
Test Logs
|
charlotteliang changed the title 
paulb777 reviewed Jun 3, 2021
maksymmalyhin approved these changes Jun 7, 2021
ncooke3 reviewed Jun 7, 2021
paulb777 reviewed Jun 7, 2021
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
maksymmalyhin added a commit that referenced this pull request Jul 29, 2021
…livery signal that exports to BigQuery." (#8458) * Revert "Prevent firelog from logging invalid data (#8443)" This reverts commit 7fc7325. * Revert "Update changelog (#8440)" This reverts commit ecc7d6d. * Revert " Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. (#6181)" This reverts commit ce87d25.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got approved within our team to proceed with this launch. Please review this again, the API review is approved at
go/fm-ios-delivery