Remove migration logic from document folder to application folder#4033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…s only used by local class and the parameter is just instance variable
paulb777 approved these changes Oct 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to store files in document folder (more than 2 years ago) and had migration logic that if document folder exist, move the content to application folder.
Remove the migration logic since the majority of the users already store data in the application folder. The data we wrote in the disks are plist file and cached non-ack mcs channel message IDs, which are not critical information even if a very old user still kept the document folder (who hasn't opened his app for more than 2 years).
Also remove production code that is only used for testing, should expose the method through category instead.