[Vertex AI] Log warning for unsupported model names#14610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…Model initializers. This change adds a warning message to the initializers of GenerativeModel and ImagenModel. The warning is logged when the provided model name does not start with the expected prefix ("gemini-" for GenerativeModel and "imagen-" for ImagenModel). The warning message includes a link to the documentation for supported models. The changes were tested manually, but automated tests could not be run due to an unavailable test environment.
This comment was marked as resolved.
This comment was marked as resolved.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a warning message when the provided model name does not start with the expected prefix for GenerativeModel and ImagenModel. This is a good addition to help developers use the SDK correctly. The implementation is clear and straightforward.
Merge Readiness
The code changes are well-implemented and the added warning messages will be helpful for developers. I don't see any issues that would block merging this pull request, but as always, I am unable to directly approve the pull request and recommend that others review and approve this code before merging.
rlazo added a commit to firebase/firebase-android-sdk that referenced this pull request Mar 25, 2025
Added a warning message to the initializers of GenerativeModel and ImagenModel that is logged when the provided model name does not start with the expected prefix ("gemini-" for GenerativeModel and "imagen-" for ImagenModel). The warning message includes a link to the documentation for supported models. Note: No error is thrown in case the naming scheme is changed in the future, though we would want to update the logic/message at that time. Related iOS PR firebase/firebase-ios-sdk#14610rlazo added a commit to firebase/firebase-android-sdk that referenced this pull request Mar 25, 2025
Added a warning message to the initializers of GenerativeModel and ImagenModel that is logged when the provided model name does not start with the expected prefix ("gemini-" for GenerativeModel and "imagen-" for ImagenModel). The warning message includes a link to the documentation for supported models. Note: No error is thrown in case the naming scheme is changed in the future, though we would want to update the logic/message at that time. Related iOS PR firebase/firebase-ios-sdk#14610andrewheard added a commit that referenced this pull request Mar 28, 2025
andrewheard added a commit that referenced this pull request Mar 28, 2025
tejasd pushed a commit to firebase/firebase-android-sdk that referenced this pull request Apr 1, 2025
Added a warning message to the initializers of GenerativeModel and ImagenModel that is logged when the provided model name does not start with the expected prefix ("gemini-" for GenerativeModel and "imagen-" for ImagenModel). The warning message includes a link to the documentation for supported models. Note: No error is thrown in case the naming scheme is changed in the future, though we would want to update the logic/message at that time. Related iOS PR firebase/firebase-ios-sdk#14610Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a warning message to the initializers of
GenerativeModelandImagenModelthat is logged when the provided model name does not start with the expected prefix ("gemini-"forGenerativeModeland"imagen-"forImagenModel). The warning message includes a link to the documentation for supported models.Note: No error is thrown in case the naming scheme is changed in the future, though we would want to update the logic/message at that time.