Skip to content

[VertexAI] Add support for token-based usage metrics#14406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 11, 2025

Conversation

rlazo
Copy link
Contributor

Token measurement is broken down by modaliy, with separate counters for image, audio, etc.

Token measurement is broken down by modaliy, with separate counters for image, audio, etc.
@rlazo
Copy link
ContributorAuthor

rlazo commented Feb 8, 2025

friendly ping

@rlazorlazo enabled auto-merge (squash) February 8, 2025 04:17
@rlazorlazo requested a review from paulb777February 11, 2025 15:25
Copy link
Contributor

@andrewheardandrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor test nits.

Note: I'm going to add integration tests in a separate PR.

@rlazo
Copy link
ContributorAuthor

Comments addressed. Also, added change to make fields non-nullable

cc @andrewheard

Copy link
Contributor

@andrewheardandrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI.

@rlazorlazo merged commit 44fe5d0 into mainFeb 11, 2025
30 of 38 checks passed
@rlazorlazo deleted the rl.token.count.breakdown branch February 11, 2025 20:41
@firebasefirebase locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
@rlazo@paulb777@andrewheard@google-oss-bot
close