Skip to content

Add SIGTERM support#12881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2024
Merged

Add SIGTERM support #12881

merged 2 commits into from
May 1, 2024

Conversation

naftaly
Copy link
Contributor

@naftalynaftaly commented May 1, 2024

Added support for catching the SIGTERM signal.

All Apple OS's send SIGTERM (like any good unix based system) when they want to request a graceful termination of an application, when the app doesn't quit in those circumstances, it'll receive a SIGKILL. This often gives us the opportunity to get a stack trace where we know Apple wants the app to be terminated but don't know why (watchdog events). This is just one more piece of information that can be added to the puzzle of figuring out unexplained app terminations.

Example in the Firebase Console:
Screenshot 2024-05-01 at 3 13 13 PM

@ncooke3
Copy link
Member

ncooke3 commented May 1, 2024

Hi @naftaly, thanks for the PR! There is one CI failure: https://github.com/firebase/firebase-ios-sdk/actions/runs/8913792847/job/24481253930?pr=12881

This can be fixed by running the style script. It looks like just a trailing whitespace.

Copy link
Contributor

@themiswangthemiswang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @naftaly, LGTM!

@paulb777paulb777 added this to the 10.27.0 - M148 milestone May 1, 2024
@paulb777paulb777 merged commit 7a01452 into firebase:mainMay 1, 2024
64 checks passed
@naftalynaftaly deleted the SIGTERM branch May 1, 2024 22:07
ncooke3 added a commit that referenced this pull request May 2, 2024
ncooke3 added a commit that referenced this pull request May 2, 2024
@firebasefirebase locked and limited conversation to collaborators Jun 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
@naftaly@ncooke3@themiswang@paulb777
close