Skip to content

crash fix#11873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2023
Merged

crash fix #11873

merged 2 commits into from
Sep 29, 2023

Conversation

eldhosembabu
Copy link
Contributor

@eldhosembabueldhosembabu commented Sep 29, 2023

Fix ABTesting crash when experiment payload is empty.

This happens when testing experiment on devices. Internal Bug : b/300084397

@google-oss-bot
Copy link

google-oss-bot commented Sep 29, 2023

Coverage Report 1

Affected Products

  • FirebaseABTesting-iOS-FirebaseABTesting.framework

    Overall coverage changed from 90.53% (0e7e4f9) to 90.04% (ccff5a2) by -0.49%.

    FilenameBase (0e7e4f9)Merge (ccff5a2)Diff
    ABTConditionalUserPropertyController.m91.44%90.05%-1.39%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TaKyu6qvGX.html
@paulb777
Copy link
Member

@karenyz Please confirm this is ok from an ABTesting and Remote Config perspective

@paulb777paulb777 merged commit e638900 into masterSep 29, 2023
@paulb777paulb777 deleted the emb/fiam-crash-fix branch September 29, 2023 20:31
@firebasefirebase locked and limited conversation to collaborators Oct 30, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants
@eldhosembabu@google-oss-bot@paulb777@karenyz
close