Skip to content

Fix overlay patch mutation bug#10579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 3, 2023
Merged

Fix overlay patch mutation bug #10579

merged 4 commits into from
Jan 3, 2023

Conversation

wu-hui
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link

google-oss-bot commented Dec 15, 2022•
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.24% (391d9f2) to 88.23% (ad74432) by -0.02%.

    FilenameBase (391d9f2)Merge (ad74432)Diff
    local_documents_view.cc96.82%96.85%+0.03%
    ordered_code.cc94.39%93.90%-0.49%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kPCd1aNDtU.html
@wu-huiwu-hui requested a review from ehsannasDecember 15, 2022 14:41
ehsannas
ehsannas reviewed Dec 21, 2022
View reviewed changes
Copy link
Contributor

@ehsannasehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits below

@ehsannasehsannas merged commit 96e30e6 into masterJan 3, 2023
@ehsannasehsannas deleted the wuandy/OverlayPatchFix branch January 3, 2023 18:24
@andrewheardandrewheard mentioned this pull request Jan 10, 2023
Merged
@firebasefirebase locked and limited conversation to collaborators Feb 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore
3 participants
@wu-hui@google-oss-bot@ehsannas
close