fix: Youou never sends vibe speeds of 0

The _vibrationSpeed variable isn't updated, so on stop the device already thinks it's stopped.

Author: blackspherefollower

Buttplug.Test/Devices/Protocols/YououTests.cs

@@ -0,0 +1,101 @@
+// <copyright file="YououTests.cs" company="Nonpolynomial Labs LLC">
+// Buttplug C# Source Code File - Visit https://buttplug.io for more info about the project.
+// Copyright (c) Nonpolynomial Labs LLC. All rights reserved.
+// Licensed under the BSD 3-Clause license. See LICENSE file in the project root for full license information.
+// </copyright>
+
+// Test file, disable ConfigureAwait checking.
+// ReSharper disable ConsiderUsingConfigureAwait
+
+usingSystem.Collections.Generic;
+usingSystem.Diagnostics.CodeAnalysis;
+usingSystem.Text;
+usingSystem.Threading.Tasks;
+usingButtplug.Core.Messages;
+usingButtplug.Devices;
+usingButtplug.Devices.Configuration;
+usingButtplug.Devices.Protocols;
+usingButtplug.Test.Devices.Protocols.Utils;
+usingJetBrains.Annotations;
+usingNUnit.Framework;
+
+namespaceButtplug.Test.Devices.Protocols
+{
+[SuppressMessage("StyleCop.CSharp.DocumentationRules","SA1600:ElementsMustBeDocumented",Justification="Test classes can skip documentation requirements")]
+[TestFixture]
+publicclassYououTests
+{
+[NotNull]
+privateProtocolTestUtilstestUtil;
+
+[SetUp]
+publicasyncTaskInit()
+{
+testUtil=newProtocolTestUtils();
+awaittestUtil.SetupTest<YououProtocol>("Youou",newList<DeviceConfiguration>());
+}
+
+[Test]
+publicvoidTestAllowedMessages()
+{
+testUtil.TestDeviceAllowedMessages(newDictionary<System.Type,uint>()
+{
+{typeof(StopDeviceCmd),0},
+{typeof(SingleMotorVibrateCmd),0},
+{typeof(VibrateCmd),1},
+});
+}
+
+// StopDeviceCmd noop test handled in GeneralDeviceTests
+
+[Test]
+publicasyncTaskTestStopDeviceCmd()
+{
+varexpected=
+newList<(byte[],string)>()
+{
+(newbyte[]{0xAA,0x55,0x00,0x02,0x03,0x01,0x7B,0x01,0x85,0xFF,0x00,0x00,0x00,0x00,0x00,0x00,0x00},Endpoints.Tx),
+};
+
+awaittestUtil.TestDeviceMessage(newSingleMotorVibrateCmd(4,0.5),expected,false);
+
+expected=
+newList<(byte[],string)>()
+{
+(newbyte[]{0xAA,0x55,0x01,0x02,0x03,0x01,0x0,0x00,0xFE,0xFF,0x00,0x00,0x00,0x00,0x00,0x00,0x00},Endpoints.Tx),
+};
+
+awaittestUtil.TestDeviceMessage(newStopDeviceCmd(4),expected,false);
+}
+
+[Test]
+publicasyncTaskTestSingleMotorVibrateCmd()
+{
+varexpected=
+newList<(byte[],string)>()
+{
+(newbyte[]{0xAA,0x55,0x00,0x02,0x03,0x01,0x7B,0x01,0x85,0xFF,0x00,0x00,0x00,0x00,0x00,0x00,0x00},Endpoints.Tx),
+};
+
+awaittestUtil.TestDeviceMessage(newSingleMotorVibrateCmd(4,0.5),expected,false);
+}
+
+[Test]
+publicasyncTaskTestVibrateCmd()
+{
+varexpected=
+newList<(byte[],string)>()
+{
+(newbyte[]{0xAA,0x55,0x00,0x02,0x03,0x01,0x7B,0x01,0x85,0xFF,0x00,0x00,0x00,0x00,0x00,0x00,0x00},Endpoints.Tx),
+};
+
+awaittestUtil.TestDeviceMessage(VibrateCmd.Create(4,1,0.5,1),expected,false);
+}
+
+[Test]
+publicvoidTestInvalidVibrateCmd()
+{
+testUtil.TestInvalidVibrateCmd(1);
+}
+}
+}

Buttplug/Devices/Protocols/YououProtocol.cs

@@ -53,6 +53,7 @@ private async Task<ButtplugMessage> HandleVibrateCmd(ButtplugDeviceMessage aMsg,
 returnnewOk(cmdMsg.Id);
 }
 
+_vibratorSpeed=v.Speed;
 SentVibration=true;
 
 // Byte 2 seems to be a monotonically increasing packet id of some kind Speed seems to be