fix(input): update $viewValue when cleared

- Fix when user clicks clear button in an input element in IE, $viewValue not being correctly updated

Author: wesleycho

src/ng/directive/input.js

@@ -34,6 +34,8 @@ var WEEK_REGEXP = /^(\d{4,})-W(\d\d)$/;
 varMONTH_REGEXP=/^(\d{4,})-(\d\d)$/;
 varTIME_REGEXP=/^(\d\d):(\d\d)(?::(\d\d)(\.\d{1,3})?)?$/;
 
+varIE_INPUTS_WITH_CLEARING=['text','number','date','datetime-local','email','month','time','url','week'];
+
 varPARTIAL_VALIDATION_EVENTS='keydown wheel mousedown';
 varPARTIAL_VALIDATION_TYPES=createMap();
 forEach('date,datetime-local,month,time,week'.split(','),function(type){
@@ -1126,7 +1128,11 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
 });
 }
 
-vartimeout;
+vartimeout,oldVal;
+varviewValueUpdated=false,msieInput=msie>=10&&msie<=11;
+if(msieInput&&attr.typeinIE_INPUTS_WITH_CLEARING){
+oldVal=element.val();
+}
 
 varlistener=function(ev){
 if(timeout){
@@ -1152,10 +1158,18 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
 }
 };
 
+functionieListener(ev){
+varval=element.val();
+if(val===oldVal&&!viewValueUpdated)return;
+oldVal=val;
+viewValueUpdated=false;
+listener(ev);
+}
+
 // if the browser does support "input" event, we are fine - except on IE9 which doesn't fire the
 // input event on backspace, delete or cut
 if($sniffer.hasEvent('input')){
-element.on('input',listener);
+element.on('input',msie ? ieListener : listener);
 }else{
 vardeferListener=function(ev,input,origValue){
 if(!timeout){
@@ -1212,6 +1226,10 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
 // Workaround for Firefox validation #12102.
 varvalue=ctrl.$isEmpty(ctrl.$viewValue) ? '' : ctrl.$viewValue;
 if(element.val()!==value){
+// Workaround for IE 10 & 11 input updates #11193
+if(msieInput){
+viewValueUpdated=true;
+}
 element.val(value);
 }
 };

src/ng/sniffer.js

@@ -73,7 +73,7 @@ function $SnifferProvider() {
 // when cut operation is performed.
 // IE10+ implements 'input' event but it erroneously fires under various situations,
 // e.g. when placeholder changes, or a form is focused.
-if(event==='input'&&msie<=11)returnfalse;
+if(event==='input'&&msie<=9)returnfalse;
 
 if(isUndefined(eventSupport[event])){
 vardivElm=document.createElement('div');

test/ng/snifferSpec.js

@@ -135,7 +135,7 @@ describe('$sniffer', function() {
 // IE10+ implementation is fubared when mixed with placeholders
 mockDivElement={oninput: noop};
 
-expect($sniffer.hasEvent('input')).toBe(!(msie&&msie<=11));
+expect($sniffer.hasEvent('input')).toBe(!(msie&&msie<=9));
 });
 });