Use the exact type name in Record.__repr__ (#959)

We support Record subclasses, so include the exact type name (rather than just 'Record') in the repr() string.

Author: jparise

asyncpg/protocol/record/recordobj.c

@@ -451,16 +451,31 @@ record_subscript(ApgRecordObject* o, PyObject* item)
 }
 
 
+staticconstchar*
+get_typename(PyTypeObject*type)
+{
+assert(type->tp_name!=NULL);
+constchar*s=strrchr(type->tp_name, '.');
+if (s==NULL) {
+s=type->tp_name;
+ }
+else {
+s++;
+ }
+returns;
+}
+
+
 staticPyObject*
 record_repr(ApgRecordObject*v)
 {
 Py_ssize_ti, n;
-PyObject*keys_iter;
+PyObject*keys_iter, *type_prefix;
 _PyUnicodeWriterwriter;
 
 n=Py_SIZE(v);
 if (n==0) {
-returnPyUnicode_FromString("<Record>");
+returnPyUnicode_FromFormat("<%s>", get_typename(Py_TYPE(v)));
  }
 
 keys_iter=PyObject_GetIter(v->desc->keys);
@@ -471,16 +486,22 @@ record_repr(ApgRecordObject *v)
 i=Py_ReprEnter((PyObject*)v);
 if (i!=0) {
 Py_DECREF(keys_iter);
-returni>0 ? PyUnicode_FromString("<Record ...>") : NULL;
+if (i>0) {
+returnPyUnicode_FromFormat("<%s ...>", get_typename(Py_TYPE(v)));
+ }
+returnNULL;
  }
 
 _PyUnicodeWriter_Init(&writer);
 writer.overallocate=1;
 writer.min_length=12; /* <Record a=1> */
 
-if (_PyUnicodeWriter_WriteASCIIString(&writer, "<Record ", 8) <0) {
+type_prefix=PyUnicode_FromFormat("<%s ", get_typename(Py_TYPE(v)));
+if (_PyUnicodeWriter_WriteStr(&writer, type_prefix) <0) {
+Py_DECREF(type_prefix);
  goto error;
  }
+Py_DECREF(type_prefix);
 
 for (i=0; i<n; ++i) {
 PyObject*key;

tests/test_record.py

@@ -523,6 +523,7 @@ class MyRecord(asyncpg.Record):
 record_class=MyRecord,
  )
 self.assertIsInstance(r, MyRecord)
+self.assertEqual(repr(r), "<MyRecord a=1 b='2'>")
 
 self.assertEqual(list(r.items()), [('a', 1), ('b', '2')])
 self.assertEqual(list(r.keys()), ['a', 'b'])