Skip to content
/jdk8u-devPublic

8266187: Memory leak in appendBootClassPath()#42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8266187: Memory leak in appendBootClassPath() #42

wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123zhengyu123 commented Apr 19, 2022•
edited by openjdk bot
Loading

Backport this patch for parity with Oracle 8u331. It fixes a memory leak
and risk is low,

Bug: https://bugs.openjdk.java.net/browse/JDK-8266187
Patch: openjdk/jdk@aa90df6

The original patch does not apply cleanly. The conflict is copyright year line. Resolved manually.

The original code review thread: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-December/014484.html

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/42/head:pull/42
$ git checkout pull/42

Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/42/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 42

View PR using the GUI difftool:
$ git pr show -t 42

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/42.diff

@bridgekeeper
Copy link

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdkopenjdkbot added the rfr Pull request is ready for review label Apr 19, 2022
@mlbridge
Copy link

mlbridgebot commented Apr 19, 2022

Webrevs

@mlbridge
Copy link

mlbridgebot commented Apr 26, 2022

Mailing list message from Hohensee, Paul on jdk8u-dev:

I believe new patches go to the jdk8u-dev github repo, not the old mercurial one.

Thanks,
Paul

?-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Zhengyu Gu <zgu at openjdk.java.net>
Date: Tuesday, April 19, 2022 at 7:45 AM
To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
Subject: [jdk8u-dev] RFR: 8266187: Memory leak in appendBootClassPath()

ackport this patch for parity with Oracle 8u331. It fixes a memory leak
and risk is low,

Bug: https://bugs.openjdk.java.net/browse/JDK-8266187
Patch: https://github.com/openjdk/jdk/commit/aa90df6f51940a73f9aa078a32768855c8568034

The original patch does not apply cleanly. The conflict is copyright year line. Resolved manually.

The original code review thread: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-December/014484.html

-------------

Commit messages:
- 8266187: Memory leak in appendBootClassPath()

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/42/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=42&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8266187
Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk8u-dev/pull/42.diff
Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/42/head:pull/42

PR: https://git.openjdk.java.net/jdk8u-dev/pull/42

@mlbridge
Copy link

mlbridgebot commented Apr 26, 2022

Mailing list message from Hohensee, Paul on jdk8u-dev:

Whoops, never mind, didn't read all the way to the bottom (

?-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of "Hohensee, Paul" <hohensee at amazon.com>
Date: Tuesday, April 26, 2022 at 11:42 AM
To: Zhengyu Gu <zgu at openjdk.java.net>, "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
Subject: Re: [jdk8u-dev] RFR: 8266187: Memory leak in appendBootClassPath()

I believe new patches go to the jdk8u-dev github repo, not the old mercurial one.

Thanks,
Paul

-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Zhengyu Gu <zgu at openjdk.java.net>
Date: Tuesday, April 19, 2022 at 7:45 AM
To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
Subject: [jdk8u-dev] RFR: 8266187: Memory leak in appendBootClassPath()

ackport this patch for parity with Oracle 8u331. It fixes a memory leak
and risk is low,

Bug: https://bugs.openjdk.java.net/browse/JDK-8266187
Patch: https://github.com/openjdk/jdk/commit/aa90df6f51940a73f9aa078a32768855c8568034

The original patch does not apply cleanly. The conflict is copyright year line. Resolved manually.

The original code review thread: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-December/014484.html

-------------

Commit messages:
- 8266187: Memory leak in appendBootClassPath()

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/42/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=42&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8266187
Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk8u-dev/pull/42.diff
Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/42/head:pull/42

PR: https://git.openjdk.java.net/jdk8u-dev/pull/42

@jerboaa
Copy link
Contributor

@zhengyu123 Please use Backport aa90df6f51940a73f9aa078a32768855c8568034 as the PR title as this is a backport. I see a "issue not open warning" for the associated bug.

@jerboaa
Copy link
Contributor

I think this can also be marked /clean as it's only path reshuffling from the original patch.

@zhengyu123zhengyu123 changed the title 8266187: Memory leak in appendBootClassPath()Backport aa90df6f51940a73f9aa078a32768855c8568034May 24, 2022
@zhengyu123
Copy link
ContributorAuthor

/clean

@openjdkopenjdkbot changed the title Backport aa90df6f51940a73f9aa078a32768855c85680348266187: Memory leak in appendBootClassPath()May 24, 2022
@openjdk
Copy link

openjdkbot commented May 24, 2022

This backport pull request has now been updated with issue from the original commit.

@zhengyu123
Copy link
ContributorAuthor

I think this can also be marked /clean as it's only path reshuffling from the original patch.

Done.

Thanks.

@openjdkopenjdkbot added the clean label May 24, 2022
@openjdk
Copy link

openjdkbot commented May 24, 2022

@zhengyu123 This backport pull request is now marked as clean

@openjdk
Copy link

openjdkbot commented May 24, 2022•
edited
Loading

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266187: Memory leak in appendBootClassPath()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdkopenjdkbot added the ready Pull request is ready to be integrated label May 24, 2022
@zhengyu123
Copy link
ContributorAuthor

/integrate

@openjdk
Copy link

openjdkbot commented May 24, 2022

Going to push as commit d35dea7.
Since your change was applied there have been 42 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdkopenjdkbot added the integrated Pull request has been integrated label May 24, 2022
@openjdkopenjdkbot closed this May 24, 2022
@openjdkopenjdkbot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2022
@openjdk
Copy link

openjdkbot commented May 24, 2022

@zhengyu123 Pushed as commit d35dea7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backportcleanintegratedPull request has been integrated
2 participants
@zhengyu123@jerboaa
close