Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/jdk15u-devPublic archive

8225082: Remove IdenTrust certificate that is expiring in September 2021#117

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-tooyan-too commented Oct 20, 2021

Remove expired certificate identrustdstx3. There is a replacement. Test failed before and well, not failed on this certificate but there will be another fix, to JDK-8225083, to make it pass. A last chunk in the test change was removed so it is not exactly clean port.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8225082: Remove IdenTrust certificate that is expiring in September 2021

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/117/head:pull/117
$ git checkout pull/117

Update a local copy of the PR:
$ git checkout pull/117
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/117/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 117

View PR using the GUI difftool:
$ git pr show -t 117

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/117.diff

@bridgekeeper
Copy link

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdkopenjdkbot changed the title Backport 2ec45dc2dd3a6bcb4f68ee7cde5858d63614305a8225082: Remove IdenTrust certificate that is expiring in September 2021Oct 20, 2021
@openjdk
Copy link

openjdkbot commented Oct 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdkopenjdkbot added backport rfr Pull request is ready for review labels Oct 20, 2021
@mlbridge
Copy link

mlbridgebot commented Oct 20, 2021

Webrevs

bae
bae approved these changes Oct 20, 2021
@openjdk
Copy link

openjdkbot commented Oct 20, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8225082: Remove IdenTrust certificate that is expiring in September 2021 Reviewed-by: bae 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdkopenjdkbot added the ready Pull request is ready to be integrated label Oct 20, 2021
@yan-too
Copy link
CollaboratorAuthor

/integrate

@openjdk
Copy link

openjdkbot commented Oct 21, 2021

Going to push as commit ad7bcf6.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 5075dec: 8274840: Update OS detection code to recognize Windows 11

Your commit was automatically rebased without conflicts.

@openjdkopenjdkbot closed this Oct 21, 2021
@openjdkopenjdkbot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2021
@openjdk
Copy link

openjdkbot commented Oct 21, 2021

@yan-too Pushed as commit ad7bcf6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-tooyan-too deleted the rmcacert branch October 21, 2021 07:43
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backportintegratedPull request has been integrated
2 participants
@yan-too@bae
close