Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/jdk15u-devPublic archive

8259343: [macOS] Update JNI error handling in Cocoa code.#10

Closed
wants to merge 1 commit into from
Closed

8259343: [macOS] Update JNI error handling in Cocoa code. #10

wants to merge 1 commit into from

Conversation

VladimirKempik
Copy link

@VladimirKempikVladimirKempik commented Apr 2, 2021

Important prerequest of JNF removal pacthes, patch 4/8
Applies cleanly


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259343: [macOS] Update JNI error handling in Cocoa code.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/10/head:pull/10
$ git checkout pull/10

Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/10/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10

View PR using the GUI difftool:
$ git pr show -t 10

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/10.diff

@bridgekeeper
Copy link

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdkopenjdkbot changed the title Backport d6a2105b5c9b44c04cac7385756ec9924c1310ab8259343: [macOS] Update JNI error handling in Cocoa code.Apr 2, 2021
@openjdk
Copy link

openjdkbot commented Apr 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdkbot commented Apr 2, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259343: [macOS] Update JNI error handling in Cocoa code. 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdkopenjdkbot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2021
@VladimirKempik
Copy link
Author

/integrate

@openjdkopenjdkbot closed this Apr 2, 2021
@openjdkopenjdkbot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2021
@openjdk
Copy link

openjdkbot commented Apr 2, 2021

@VladimirKempik Pushed as commit e688dae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempikVladimirKempik deleted the backport-d6a2105b5c9b44c04cac7385756ec9924c1310ab branch April 2, 2021 09:13
@mlbridge
Copy link

mlbridgebot commented Apr 2, 2021

Webrevs

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backportcleanintegratedPull request has been integrated
1 participant
@VladimirKempik
close