Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/jdk13u-devPublic archive

8227609: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size#213

Closed
wants to merge 1 commit into from

Conversation

Larry-N
Copy link
Contributor

@Larry-NLarry-N commented May 17, 2021

Backport fix JDK-8227609 (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8227609: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/213/head:pull/213
$ git checkout pull/213

Update a local copy of the PR:
$ git checkout pull/213
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/213/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 213

View PR using the GUI difftool:
$ git pr show -t 213

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/213.diff

@bridgekeeper
Copy link

👋 Welcome back Larry-N! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdkopenjdkbot changed the title Backport 3155cd829b56d9d44f47b607bad34db27d8b6d6a8227609: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file sizeMay 17, 2021
@openjdk
Copy link

openjdkbot commented May 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdkbot commented May 17, 2021

@Larry-N This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8227609: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdkopenjdkbot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2021
@Larry-N
Copy link
ContributorAuthor

/integrate

@openjdkopenjdkbot added the sponsor Pull request is ready to be sponsored label May 17, 2021
@openjdk
Copy link

openjdkbot commented May 17, 2021

@Larry-N
Your change (at version 826cc4b) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridgebot commented May 17, 2021

Webrevs

@yan-too
Copy link
Collaborator

/sponsor

@openjdkopenjdkbot closed this May 17, 2021
@openjdkopenjdkbot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2021
@openjdk
Copy link

openjdkbot commented May 17, 2021

@yan-too@Larry-N Pushed as commit 32036b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Larry-NLarry-N deleted the backport-3155cd82 branch May 17, 2021 14:01
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backportcleanintegratedPull request has been integrated
2 participants
@Larry-N@yan-too
close