Skip to content

8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check#108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerrTheRealMDoerr commented Jul 7, 2021

This trivial null check fix should get backported for parity with 11.0.13-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/108/head:pull/108
$ git checkout pull/108

Update a local copy of the PR:
$ git checkout pull/108
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/108/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 108

View PR using the GUI difftool:
$ git pr show -t 108

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/108.diff

@bridgekeeper
Copy link

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdkopenjdkbot changed the title Backport 4ad8b04421f3142c396ade26f36334da7a915b5b8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null checkJul 7, 2021
@openjdk
Copy link

openjdkbot commented Jul 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdkbot commented Jul 7, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdkopenjdkbot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2021
@mlbridge
Copy link

mlbridgebot commented Jul 7, 2021

Webrevs

@TheRealMDoerr
Copy link
ContributorAuthor

/integrate

@openjdk
Copy link

openjdkbot commented Jul 8, 2021

Going to push as commit c44da65.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 2beb7e7: 8218145: block_if_requested is not proper inlined due to size
  • 02c0cf6: 8267424: CTW: C1 fails with "State must not be null"
  • bdf8568: 8250588: Shenandoah: LRB needs to save/restore fp registers for runtime call

Your commit was automatically rebased without conflicts.

@openjdkopenjdkbot closed this Jul 8, 2021
@openjdkopenjdkbot added the integrated Pull request has been integrated label Jul 8, 2021
@TheRealMDoerrTheRealMDoerr deleted the 8268369_C2 branch July 8, 2021 12:42
@openjdkopenjdkbot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2021
@openjdk
Copy link

openjdkbot commented Jul 8, 2021

@TheRealMDoerr Pushed as commit c44da65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backportcleanintegratedPull request has been integrated
1 participant
@TheRealMDoerr
close