7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead.#339

prrace · 2020-09-24T16:38:50Z

A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006

The fix is to propagate whatever is set as the Destination down to native and set it on the native printing object.

Also if using the native dialog, but with attributes, copy back the destination from native to the Java attribute set.

The new test can directly test printing to file in an automated way - so long as there is a printer.

The updated manual test can be used to verify the cross-platform dialog case.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead ⚠️ Title mismatch between PR and JBS.

Reviewers

Sergey Bylokhov (@mrserb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/339/head:pull/339
$ git checkout pull/339

… printer instead

bridgekeeper · 2020-09-24T16:40:12Z

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-09-24T16:41:21Z

@prrace The following label will be automatically applied to this pull request: awt.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

prrace · 2020-09-24T16:43:48Z

label /remove awt

prrace · 2020-09-24T16:44:01Z

/label add 2d

openjdk · 2020-09-24T16:44:44Z

@prrace
The 2d label was successfully added.

prrace · 2020-09-24T16:46:32Z

/label remove awt

openjdk · 2020-09-24T16:47:01Z

@prrace
The awt label was successfully removed.

mlbridge · 2020-09-24T16:50:41Z

Webrevs

mrserb · 2020-09-25T01:32:49Z

src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m

+ //NSURL *nsURL = [NSURL URLWithString:nsDestStr];
+ NSURL *nsURL = [NSURL fileURLWithPath:nsDestStr isDirectory:NO];
+ [printingDictionary setObject:nsURL forKey:NSPrintJobSavingURL];
+// JNFCallVoidMethod(env, dstPrinterJob, jm_setPrintToFile, true);


Does it look like the commented lines are not needed?

Hmm. I could swear I removed those and re-ordered the first two lines as well.

prsadhuk · 2020-09-25T04:30:09Z

test/jdk/java/awt/print/PrinterJob/PrintToFileTest.java

+ pj.print(pSet);
+ if (!file.exists()) {
+ throw new RuntimeException("No file created");
+ }


I guess we need to delete the file in finally block, if created.

I meant to leave it. So we can look at it if we need to.

prsadhuk · 2020-09-25T04:57:48Z

src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java

@@ -251,6 +253,22 @@ private void setPrintToFile(boolean printToFile) {
 isPrintToFile = printToFile;
 }

+ private void setDestinationFile(String dest) {
+ System.out.println("dest="+dest+" attrs="+attributes);


Probably this println should be removed.

… printer instead.

mrserb · 2020-09-25T21:31:01Z

src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java

+ try {
+ URI destURI = new URI(dest);
+ attributes.add(new Destination(destURI));
+ destinationAttr = "" + destURI.getSchemeSpecificPart();


This destinationAttr in the RasterPrinterJob is usually assigned to:
destinationAttr = "" + new File(destination.getURI().
getSchemeSpecificPart());
Do we need to do the same here?

I see that in WPrinterJob.java we do the same as I am doing here.
I think the difference in RPJ may bethat we want to get a full path name which is what the new File did.
Here macOS gives us a full path name already. So I don't think it is needed.
It gave the required value for sure.

mrserb · 2020-09-25T21:33:42Z

src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m

+ NSURL *url = [printingDictionary objectForKey:NSPrintJobSavingURL];
+ NSString *nsStr = [url absoluteString];
+ jstring str = JNFNSToJavaString(env, nsStr);
+ JNFCallVoidMethod(env, dstPrinterJob, jm_setDestinationFile, str);
 } else {
 JNFCallVoidMethod(env, dstPrinterJob, jm_setPrintToFile, false);
 }

 // get the selected printer's name, and set the appropriate PrintService on the Java side


The comment need to be moved up as well?

prrace · 2020-09-25T23:40:40Z

Updated with the comment moved.

… printer instead

openjdk · 2020-09-26T00:49:37Z

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead. Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

b66fa8f: 8253572: [windows] CDS archive may fail to open with long file names
4167540: 8253647: Remove dead code in os::create_thread() on Linux/BSD
5a57945: 8231591: [TESTBUG] Create additional two phase jpackage tests
b159e4e: 8253149: Building an installer from invalid app image fails on Window…
0e855fe: 8252377: Incorrect encoding for EC AlgorithmIdentifier
9150b90: 8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64
0187567: 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 …
a75edc2: 8251188: Update LDAP tests not to use wildcard addresses
1f5a033: 8253555: Make ByteSize and WordSize typed scoped enums
f62eefc: 8253469: ARM32 Zero: replace usages of __sync_synchronize() with OrderAccess::fence
... and 42 more: https://git.openjdk.java.net/jdk/compare/0f26ab16ddf10cefc0b528aa12c7c2378a864063...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

prrace · 2020-09-26T04:13:31Z

/integrate

openjdk · 2020-09-26T04:15:48Z

@prrace Since your change was applied there have been 52 commits pushed to the master branch:

b66fa8f: 8253572: [windows] CDS archive may fail to open with long file names
4167540: 8253647: Remove dead code in os::create_thread() on Linux/BSD
5a57945: 8231591: [TESTBUG] Create additional two phase jpackage tests
b159e4e: 8253149: Building an installer from invalid app image fails on Window…
0e855fe: 8252377: Incorrect encoding for EC AlgorithmIdentifier
9150b90: 8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64
0187567: 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 …
a75edc2: 8251188: Update LDAP tests not to use wildcard addresses
1f5a033: 8253555: Make ByteSize and WordSize typed scoped enums
f62eefc: 8253469: ARM32 Zero: replace usages of __sync_synchronize() with OrderAccess::fence
... and 42 more: https://git.openjdk.java.net/jdk/compare/0f26ab16ddf10cefc0b528aa12c7c2378a864063...master

Your commit was automatically rebased without conflicts.

Pushed as commit ea7c47c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

7179006: [macosx] Print-to-file doesn't work: printing to the default…
048c7ee
… printer instead

openjdkbot added the rfr Pull request is ready for review label Sep 24, 2020

openjdkbot added the awt client-libs-dev@openjdk.org label Sep 24, 2020

openjdkbot added the 2d client-libs-dev@openjdk.org label Sep 24, 2020

openjdkbot removed the awt client-libs-dev@openjdk.org label Sep 24, 2020

mrserb reviewed Sep 25, 2020
View reviewed changes

prsadhuk reviewed Sep 25, 2020
View reviewed changes

7179006: [macosx] Print-to-file doesn't work: printing to the default…
0165ae2
… printer instead.

mrserb reviewed Sep 25, 2020
View reviewed changes

7179006: [macosx] Print-to-file doesn't work: printing to the default…
ff4c783
… printer instead

mrserb approved these changes Sep 26, 2020
View reviewed changes

openjdkbot added the ready Pull request is ready to be integrated label Sep 26, 2020

openjdkbot closed this Sep 26, 2020

openjdkbot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 26, 2020

prrace deleted the print_to_file branch October 2, 2020 22:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead.#339

7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead. #339

prrace commented Sep 24, 2020•
edited by openjdk bot
Loading

bridgekeeperbot commented Sep 24, 2020

openjdkbot commented Sep 24, 2020

prrace commented Sep 24, 2020

prrace commented Sep 24, 2020

openjdkbot commented Sep 24, 2020

prrace commented Sep 24, 2020

openjdkbot commented Sep 24, 2020

mlbridgebot commented Sep 24, 2020•
edited
Loading

mrserbSep 25, 2020

prraceSep 25, 2020

prsadhukSep 25, 2020

prraceSep 25, 2020

prsadhukSep 25, 2020

prraceSep 25, 2020

mrserbSep 25, 2020

prraceSep 25, 2020

mrserbSep 25, 2020

prrace commented Sep 25, 2020

openjdkbot commented Sep 26, 2020•
edited
Loading

prrace commented Sep 26, 2020

openjdkbot commented Sep 26, 2020

7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead.#339

7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead. #339

Conversation

prrace commented Sep 24, 2020• edited by openjdk botLoading

Progress

Issue

Reviewers

Download

bridgekeeperbot commented Sep 24, 2020

openjdkbot commented Sep 24, 2020

prrace commented Sep 24, 2020

prrace commented Sep 24, 2020

openjdkbot commented Sep 24, 2020

prrace commented Sep 24, 2020

openjdkbot commented Sep 24, 2020

mlbridgebot commented Sep 24, 2020• edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prrace commented Sep 25, 2020

openjdkbot commented Sep 26, 2020• edited Loading

prrace commented Sep 26, 2020

openjdkbot commented Sep 26, 2020

prrace commented Sep 24, 2020•
edited by openjdk bot
Loading

mlbridgebot commented Sep 24, 2020•
edited
Loading

openjdkbot commented Sep 26, 2020•
edited
Loading