Skip to content

8258554: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F#1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhukprsadhuk commented Dec 17, 2020

This test tests whether creation of Renderers and Editors are delayed but in nimbus and subseqeuently in GTK L&F the renderers are created in installDefaults() [1] itself so it fails in GTKL&F.
As nimbus is already skipped in the test, it is modified to skip GTK L&F too. Along with this modification, the test is also updated to test all installed L&Fs.
Mach5 job running for several iterations for all platform is ok. Link in JBS.

[1] https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTableUI.java#L118


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258554: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1813/head:pull/1813
$ git checkout pull/1813

@bridgekeeper
Copy link

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdkbot commented Dec 17, 2020

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdkopenjdkbot added the swing client-libs-dev@openjdk.org label Dec 17, 2020
@openjdkopenjdkbot added the rfr Pull request is ready for review label Dec 17, 2020
@mlbridge
Copy link

mlbridgebot commented Dec 17, 2020

Webrevs

@openjdk
Copy link

openjdkbot commented Dec 18, 2020

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258554: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F Reviewed-by: serb 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 99 new commits pushed to the master branch:

  • 6a78b2a: 8258645: Bring Jemmy 1.3.11 to JDK test base
  • 7f92d18: 8258553: Limit number of fields in instance to be considered for scalar replacement
  • adf0e23: 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume
  • 06c24e1: 8256213: Remove os::split_reserved_memory
  • be41468: 8258696: Temporarily revert use of pattern match instanceof until docs-reference is fixed
  • a4f393c: 8258661: Inner class ResponseCacheEntry could be static
  • 3c48819: 8169086: DTLS tests fail intermittently with too much loops or timeout
  • 71ae05d: 8258061: Improve diagnostic information about errors during class redefinition
  • 68f2acb: 8252055: Use java.util.HexFormat in java.security
  • 1dae45d: 8250523: Remove abortOnException diagnostic option from TestHumongousNonArrayAllocation.java
  • ... and 89 more: https://git.openjdk.java.net/jdk/compare/2ee795d9e495ea5cb6e1a41f48406291dc0e5e58...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdkopenjdkbot added the ready Pull request is ready to be integrated label Dec 18, 2020
@prsadhuk
Copy link
ContributorAuthor

/integrate

@openjdkopenjdkbot closed this Dec 19, 2020
@openjdkopenjdkbot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2020
@prsadhukprsadhuk deleted the JDK-8258554 branch December 19, 2020 12:00
@openjdk
Copy link

openjdkbot commented Dec 19, 2020

@prsadhuk Since your change was applied there have been 101 commits pushed to the master branch:

  • c50b464: 8258715: [JVMCI] separate JVMCI code install timers for CompileBroker and hosted compilations
  • 64644a1: 8253881: Hotspot/Serviceability Terminology Refresh
  • 6a78b2a: 8258645: Bring Jemmy 1.3.11 to JDK test base
  • 7f92d18: 8258553: Limit number of fields in instance to be considered for scalar replacement
  • adf0e23: 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume
  • 06c24e1: 8256213: Remove os::split_reserved_memory
  • be41468: 8258696: Temporarily revert use of pattern match instanceof until docs-reference is fixed
  • a4f393c: 8258661: Inner class ResponseCacheEntry could be static
  • 3c48819: 8169086: DTLS tests fail intermittently with too much loops or timeout
  • 71ae05d: 8258061: Improve diagnostic information about errors during class redefinition
  • ... and 91 more: https://git.openjdk.java.net/jdk/compare/2ee795d9e495ea5cb6e1a41f48406291dc0e5e58...master

Your commit was automatically rebased without conflicts.

Pushed as commit c7c53d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integratedPull request has been integratedswingclient-libs-dev@openjdk.org
2 participants
@prsadhuk@mrserb
close