prioritize session file path over local storage (#553)

* prioritize session file path over local storage Signed-off-by: shmck <shawn.j.mckay@gmail.com> * move local storage lookup later Signed-off-by: shmck <shawn.j.mckay@gmail.com>

Author: ShMcK

src/services/storage/index.ts

@@ -30,12 +30,9 @@ class Storage<T> {
 this.defaultValue=defaultValue
 }
 publicget=async(): Promise<T>=>{
-constvalue: string|undefined=awaitthis.storage.get(this.key)
-if(value){
-returnJSON.parse(value)
-}elseif(SESSION_STORAGE_PATH){
+if(SESSION_STORAGE_PATH){
 try{
-// optionally read from file as a fallback to local storage
+// 1. read from file instead of local storage if specified
 constsessionFile=awaitreadFile(SESSION_STORAGE_PATH,`${this.filePath}.json`)
 if(!sessionFile){
 thrownewError('No session file found')
@@ -53,6 +50,16 @@ class Storage<T> {
 console.warn(`Failed to read or parse session file: ${SESSION_STORAGE_PATH}/${this.filePath}.json`)
 }
 }
+constvalue: string|undefined=awaitthis.storage.get(this.key)
+if(value){
+// 2. read from local storage
+try{
+returnJSON.parse(value)
+}catch(err){
+console.warn(`Failed to parse session state from local storage: ${value}`)
+}
+}
+// 3. fallback to the default
 returnthis.defaultValue
 }
 publicset=(value: T): void=>{